Update to Cell areas and valid cells for v18/v19 version of HGCAL

[Pruthvi-ch]

PR description:

PR description:

Update Area and Offset calculation for all the cells in v19 version of partial wafers for HGCAL. Also update the definition of good cells in wafers.

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47077/43253

ERROR: Build errors found during clang-tidy run.

src/Geometry/HGCalCommonData/src/HGCalCellOffset.cc:1281:77: error: no member named 'halfTrunCell' in 'HGCalCell' [clang-diagnostic-error]
 1281 |     } else if ((cellType == HGCalCell::halfCell) || (cellType == HGCalCell::halfTrunCell) ||
      |                                                                  ~~~~~~~~~~~^
src/Geometry/HGCalCommonData/src/HGCalCellOffset.cc:1282:40: error: no member named 'halfExtCell' in 'HGCalCell' [clang-diagnostic-error]
 1282 |                (cellType == HGCalCell::halfExtCell) || (cellType == HGCalCell::LDPartial0714Cell) ||
      |                             ~~~~~~~~~~~^
Suppressed 456 warnings (456 in non-user code).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47077/43254

[cmsbuild]

A new Pull Request was created by @Pruthvi-ch for master.

It involves the following packages:

• Geometry/HGCalCommonData (upgrade, geometry)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

Which runTheMatrix workflows should be used to test this PR? The current Phase-2 baseline D110 has C18 = HGCal v17, so this code won't get exercised by that workflow. It looks like HGCal v18 is in C22-onward, which are in D104, D106, D109, D111, D112, D113, D116.

[Pruthvi-ch]

C22: D104, Workflow can be used.

[kpedro88]

test parameters:
workflows = 27234.0
relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,Run4

[kpedro88]

please test

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d732b8/43719/summary.html
COMMIT: 5a35263
CMSSW: CMSSW_15_0_X_2025-01-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47077/43719/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 13421 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3926277
• DQMHistoTests: Total failures: 78811
• DQMHistoTests: Total nulls: 31
• DQMHistoTests: Total successes: 3847415
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 219 log files, 188 edm output root files, 50 DQM output files
• TriggerResults: found differences in 4 / 48 workflows