Replace configuration-copying Alpaka ESProducers with MoveToDeviceCache #47047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47047/43186
|
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@Martin-Grunewald, @atpathak, @cmsbuild, @consuegs, @francescobrivio, @jfernan2, @mandrenguyen, @mmusich, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
makortel
force-pushed
the
useCachesInsteadOfESProducers
branch
from
be750b4 to
bac91f6
Compare
|
@cms-sw/heterogeneous-l2 |
|
enable gpu |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47047/43187
|
|
@cmsbuild, please test |
cmsbuild
added
tests-started
code-checks-approved
and removed
tests-pending
code-checks-pending
labels
|
Pull request #47047 was updated. @Martin-Grunewald, @atpathak, @consuegs, @francescobrivio, @jfernan2, @mandrenguyen, @mmusich, @perrotta can you please check and sign again. |
|
+1 Size: This PR adds an extra 140KB to repository Comparison SummarySummary:
GPU Comparison SummarySummary:
|
|
+1 |
makortel
force-pushed
the
useCachesInsteadOfESProducers
branch
from
2f0878d to
8fd33a8
Compare
|
unhold |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47047/43262
|
|
Pull request #47047 was updated. @Martin-Grunewald, @atpathak, @cmsbuild, @consuegs, @francescobrivio, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @mmusich, @perrotta can you please check and sign again. |
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
GPU Comparison SummarySummary:
|
|
+1
…On Fri, 10 Jan 2025, 22:23 cmsbuild, ***@***.***> wrote:
+1
*Size*: This PR adds an extra 24KB to repository
*Summary*:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-767973/43722/summary.html
*COMMIT*: 8fd33a8
<8fd33a8>
*CMSSW*: CMSSW_15_0_X_2025-01-10-1100/el8_amd64_gcc12
*Additional Tests*: GPU
*User test area*: For local testing, you can use /cvmfs/
cms-ci.cern.ch/week1/cms-sw/cmssw/47047/43722/install.sh to create a dev
area with all the needed externals and cmssw changes.
Comparison Summary
*Summary*:
- No significant changes to the logs found
- Reco comparison results: 0 differences found in the comparisons
<https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_15_0_X_2025-01-10-1100+767973/66401/validateJR.html>
- DQMHistoTests: Total files compared: 49
- DQMHistoTests: Total histograms compared: 3818780
<3818780>
- DQMHistoTests: Total failures: 61
<https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_15_0_X_2025-01-10-1100+767973/66401/validateJR.html>
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3818699
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
- Checked 214 log files, 184 edm output root files, 49 DQM output files
- TriggerResults
<https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_15_0_X_2025-01-10-1100+767973/66401/triggerResults>:
no differences found
GPU Comparison Summary
*Summary*:
- No significant changes to the logs found
- Reco comparison results: 24 differences found in the comparisons
<https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisonsGPU/CMSSW_15_0_X_2025-01-10-1100+767973/66400/validateJR.html>
- DQMHistoTests: Total files compared: 7
- DQMHistoTests: Total histograms compared: 53071
- DQMHistoTests: Total failures: 867
<https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisonsGPU/CMSSW_15_0_X_2025-01-10-1100+767973/66400/validateJR.html>
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 52204
- DQMHistoTests: Total skipped: 0
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
- Checked 24 log files, 30 edm output root files, 7 DQM output files
- TriggerResults
<https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisonsGPU/CMSSW_15_0_X_2025-01-10-1100+767973/66400/triggerResults>:
no differences found
—
Reply to this email directly, view it on GitHub
<#47047 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7BTIMGX4GCCB3Z777MOCL2KA26VAVCNFSM6AAAAABUWTBWVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBUGI3DOOJSGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
+1 |
|
@makortel this needs a rebase now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Before #43969 a common pattern to copy data from configuration to all devices was to use the EventSetup system. While that works, it adds more pieces to be managed and disconnects the configuration parameters of a module (in addition to slight abuse of EventSetup system as "a job" is not a real IOV). This PR proposes to replace such Alpaka ESProducers with the
MoveToDeviceCacheintroduced in #43969.Resolves cms-sw/framework-team#1129
PR validation:
Code compiles, matrix workflows 12834.{402,412,422} and 145.604 run with and without an NVIDIA GPU.