Update Impacts.py

[anigamova]

1. Adding possibility to process regex in --setParameters
2. Remove old iterators (createIterator()) in Impacts.py and FastScan.py

[kcormi]

Thanks Aliya. As well as the minor comment above, I noticed its not entirely clear to me what the intended difference between--setParameters and --setPhysicsModelParameters is. It looks like its maybe a relic of times long past?

There are references to it in comments of src/Combine.cc but these also seem to be mistaken and should be referring to --setParameters.

[kcormi]

I think this is meant to be inside the if block starting on l.208, or else set_parameter_str doesn't exist.

[anigamova]

Thanks for spotting this!

[anigamova]

I think --setPhysicsModelParameters is not used and replaced by --setParameters https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/main/python/tool_base/Impacts.py#L108, in Combine.cc as well
Could try to remove it, not sure if anyone is using it though

[kcormi]

I think --setPhysicsModelParameters is not used and replaced by --setParameters https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/main/python/tool_base/Impacts.py#L108, in Combine.cc as well Could try to remove it, not sure if anyone is using it though

It seems to fail if the option is used since it doesn't actually exist in combine but the tool tries to pass it through. But I can remove it in another PR. This one looks good to me.

[anigamova]

ok, I removed the --setPhysicsModelParameters option here

[kcormi]

Perfect, thanks!