Add optional range for channels in ChannelCompatibilityCheck
#760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, the user can optionally set the range of channel POIs as
This is useful in the case the POI hit the boundary in some channels, e.g. due to low sensitivity, large excess, ...
Alternatively, I also tried adding the channel POIs to
autoMaxPOIs_
orautoBoundsPOIs_
by adding this snippet toChannelCompatibilityCheck::runSpecific
. This helped with boundary issues, but it's a bit ugly, and you get an error for e.g.because this parameter does not exist before
ChannelCompatibilityCheck::runSpecific
.