generated from cloudposse/terraform-example-module
-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a variable to provide a list of IAM policy actions for the IAM service role for the Amplify app. Update custom domain configuration #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice role for the Amplify app
/test all |
/test all |
/test all |
/test all |
Nuru
reviewed
Apr 20, 2023
/test all |
/test all |
Nuru
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
domain_config
why
Amplify apps without a backend don't need an IAM role. Amplify apps with a backend need an IAM role, but many of them don't need a full set of actions as defined in the default set for the role. Allow specifying a custom set of actions for the IAM role. For example, for Amplify apps with server-side rendering, only the following IAM permissions are required (see Amazon CloudWatch Logs for SSR apps for more info)
Update custom domain configuration. Add a new variable
domain_config
. A custom domain is app-wide, not branch-wide, and needs to be specified in a separate variable (not part of the app's environments)