Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a variable to provide a list of IAM policy actions for the IAM service role for the Amplify app. Update custom domain configuration #4

Merged
merged 8 commits into from
Apr 20, 2023

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Apr 20, 2023

what

  • Add a variable to provide a list of IAM policy actions for the IAM service role for the Amplify app
  • Update custom domain configuration. Add a new variable domain_config

why

  • Amplify apps without a backend don't need an IAM role. Amplify apps with a backend need an IAM role, but many of them don't need a full set of actions as defined in the default set for the role. Allow specifying a custom set of actions for the IAM role. For example, for Amplify apps with server-side rendering, only the following IAM permissions are required (see Amazon CloudWatch Logs for SSR apps for more info)

    logs:CreateLogStream
    logs:CreateLogGroup
    logs:DescribeLogGroups
    logs:PutLogEvents
    
  • Update custom domain configuration. Add a new variable domain_config. A custom domain is app-wide, not branch-wide, and needs to be specified in a separate variable (not part of the app's environments)

@aknysh aknysh requested a review from a team as a code owner April 20, 2023 01:58
@aknysh aknysh self-assigned this Apr 20, 2023
@aknysh aknysh requested review from a team as code owners April 20, 2023 01:58
@aknysh aknysh requested review from Gowiem and korenyoni April 20, 2023 01:58
@aknysh
Copy link
Member Author

aknysh commented Apr 20, 2023

/test all

@aknysh
Copy link
Member Author

aknysh commented Apr 20, 2023

/test all

@aknysh
Copy link
Member Author

aknysh commented Apr 20, 2023

/test all

@aknysh
Copy link
Member Author

aknysh commented Apr 20, 2023

/test all

@aknysh aknysh requested review from osterman, Nuru and nitrocode April 20, 2023 03:42
@aknysh
Copy link
Member Author

aknysh commented Apr 20, 2023

/test all

@aknysh
Copy link
Member Author

aknysh commented Apr 20, 2023

/test all

@aknysh aknysh requested a review from Nuru April 20, 2023 22:08
@aknysh aknysh added the minor New features that do not break anything label Apr 20, 2023
@aknysh aknysh merged commit 9043680 into main Apr 20, 2023
@aknysh aknysh deleted the add-iam-permissions branch April 20, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants