Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(codeql-analysis): fix the workflow by using go1.21 #151

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Sep 29, 2023

What is this change about?

Fix the codeql-analysis workflow, which has been failing for a while because it's been using go1.20 with a go.mod file generated by go1.21.

Please provide contextual information.

github/codeql-action#1842 (comment)

Please check all that apply for this PR:

  • updates CI
  • introduces a new test (see *Note below)
  • changes an existing test
  • introduces a breaking change (other users will need to make manual changes when this change is released)

Did you update the README as appropriate for this change?

  • YES
  • N/A

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

None

This workflow has been failing for a while because it's been using
go1.20, which is incompatible with the go.mod file generated by go1.21
:/.

I found this solution from:
github/codeql-action#1842 (comment).
@ctlong ctlong linked an issue Sep 29, 2023 that may be closed by this pull request
@ctlong ctlong requested a review from a team September 29, 2023 17:14
Copy link

@chombium chombium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ctlong ctlong merged commit 2df4905 into main Oct 10, 2023
@ctlong ctlong deleted the ci/codeql-analysis/use-go-1.21 branch October 10, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeQL scanning fails due to autobuild not supporting go1.21
4 participants