Make workflow instance.status() return output equal to production workflows
#7575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously,in local dev, the `output` field would return the list of successful steps outputs in the workflow. This is not expected behaviour compared to production workflows (where the output is the actual return of the `run` function), probably just a implementation detail not set left-over from before beta. This commit makes it so that `output` is equal to production behaviour. For observability sake, I kept the old step output list in a different field `__LOCAL_DEV_STEP_OUTPUTS` - I think this is a good enough compromise right now since we want local dev to be correct against prod first. We can remove `__LOCAL_DEV_STEP_OUTPUTS` later, once we figure out on how to add custom stuff to the devtools page.
🦋 Changeset detectedLatest commit: f165792 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12412537996/npm-package-wrangler-7575You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7575/npm-package-wrangler-7575Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12412537996/npm-package-wrangler-7575 dev path/to/script.jsAdditional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12412537996/npm-package-cloudflare-workers-bindings-extension-7575 -O ./cloudflare-workers-bindings-extension.0.0.0-v005af7b70.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v005af7b70.vsixnpx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12412537996/npm-package-create-cloudflare-7575 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12412537996/npm-package-cloudflare-kv-asset-handler-7575npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12412537996/npm-package-miniflare-7575npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12412537996/npm-package-cloudflare-pages-shared-7575npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12412537996/npm-package-cloudflare-unenv-preset-7575npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12412537996/npm-package-cloudflare-vitest-pool-workers-7575npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12412537996/npm-package-cloudflare-workers-editor-shared-7575npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12412537996/npm-package-cloudflare-workers-shared-7575npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12412537996/npm-package-cloudflare-workflows-shared-7575Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
LuisDuarte1
force-pushed
the
lduarte/workflows-get-status-binding-local-dev
branch
from
f6670eb to
9fa4053
Compare
andyjessop
reviewed
Dec 18, 2024
|
I think we'll need E2E tests here because we test workflows in our dev E2E suite. |
CarmenPopoviciu
deleted the
lduarte/workflows-get-status-binding-local-dev
branch
Merged
emily-shen
pushed a commit
that referenced
this pull request
Dec 19, 2024
…orkflows (#7575) * feat: Make `instance.status()` return output equal to production Previously,in local dev, the `output` field would return the list of successful steps outputs in the workflow. This is not expected behaviour compared to production workflows (where the output is the actual return of the `run` function), probably just a implementation detail not set left-over from before beta. This commit makes it so that `output` is equal to production behaviour. For observability sake, I kept the old step output list in a different field `__LOCAL_DEV_STEP_OUTPUTS` - I think this is a good enough compromise right now since we want local dev to be correct against prod first. We can remove `__LOCAL_DEV_STEP_OUTPUTS` later, once we figure out on how to add custom stuff to the devtools page. * fix types * fix tests * chore: add better types for readLogs
penalosa
pushed a commit
that referenced
this pull request
Jan 10, 2025
…orkflows (#7575) * feat: Make `instance.status()` return output equal to production Previously,in local dev, the `output` field would return the list of successful steps outputs in the workflow. This is not expected behaviour compared to production workflows (where the output is the actual return of the `run` function), probably just a implementation detail not set left-over from before beta. This commit makes it so that `output` is equal to production behaviour. For observability sake, I kept the old step output list in a different field `__LOCAL_DEV_STEP_OUTPUTS` - I think this is a good enough compromise right now since we want local dev to be correct against prod first. We can remove `__LOCAL_DEV_STEP_OUTPUTS` later, once we figure out on how to add custom stuff to the devtools page. * fix types * fix tests * chore: add better types for readLogs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in local dev, the
outputfield would return the list of successful steps outputs in the workflow. This is not expected behavior compared to production workflows (where the output is the actual return of therunfunction), probably just an implementation detail not set left-over from before beta.This commit makes it so that
outputis equal to production behavior.For observability’s sake, I kept the old step output list in a different field
__LOCAL_DEV_STEP_OUTPUTS- I think this is a good enough compromise right now since we want local dev to be correct against prod first. We can remove__LOCAL_DEV_STEP_OUTPUTSlater, once we figure out on how to add custom stuff to the devtools page.