create page rule to return the page rule object - quick fix? #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elithrar
approved these changes
Feb 26, 2018
|
@benjvi approved. Let me know when it also makes sense to tag a new release w/ the breaking changes, so you can vendor against a version (instead of a commit ref or HEAD) in the Terraform provider. |
|
Awesome -thanks @elithrar . Will do - I'm not planning to make any more changes to this library at the moment but I still have a few things to look at so something else might turn up. Still could be worth tagging in the meantime? - up to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the simplest possible thing to get creation of page rules to be usable in terraform or other automation by returning the page rule object. I also added a bunch of tests while I'm here
I'm aware there is related some discussion and parallel work going on in #154, happy to align with that just trying to get something in quickly
Of course - this is still a breaking change