Rate limiting (for a zone) #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesog
reviewed
Feb 15, 2018
rate_limiting.go
Outdated
|
|
||
| import ( | ||
| "encoding/json" | ||
| "github.com/pkg/errors" |
There was a problem hiding this comment.
Nit: the style elsewhere in this project (presumably because most people are using goimports) is to put external imports at the end, after a blank line.
rate_limiting_example_test.go
Outdated
|
|
||
| import ( | ||
| "fmt" | ||
| cloudflare "github.com/cloudflare/cloudflare-go" |
rate_limiting.go
Outdated
| // RateLimit is a policy than can be applied to limit traffic within a customer domain | ||
| type RateLimit struct { | ||
| ID string `json:"id,omitempty"` | ||
| Disabled bool `json:"disabled,omitempty"` // api defaults to false |
There was a problem hiding this comment.
Not sure if the comment is necessary here as bool also defaults to false
+ cleanup review comments
benjvi
force-pushed
the
rate-limiting
branch
from
27b4a26 to
d42835d
Compare
|
Thanks guys. I addressed the comments from @jamesog, also I realised today that the empty struct values were different than the api defaults when completely omitting a field in a couple of places - |
elithrar
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the rate limiting API. Mostly standard CRUD calls to API with marshalling etc. For listing, I allowed the caller to specify pagination options or call ListAll directly