Add AttributeValue::Binary; align order of AttributeValue with spec #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bobby Calderwood <[email protected]>
bobby
force-pushed
the
align-spec-types-binary
branch
from
56b7b38 to
f9236c4
Compare
|
Hello maintainers @jcrossley3 @linuxbasic, @slinkydeveloper, @Lazzaretti, Thank you for this library, your work is very much appreciated! Any interest in this contribution? This issue was blocking me, and so I assume I'm not the only one bitten. |
jcrossley3
approved these changes
Nov 20, 2024
Lazzaretti
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
Binarytype from the specification isn't included in theAttributeValueenum, which misaligns serialization/deserialization to/from various formats including protobuf/prost. This PR adds support for Binary attribute values.