[CIVP-18964] Update Notebook Package Version #50
Conversation
aehrmann
changed the title
| # for versions of jupyter before 5.7.5 we need to specify tornado<6 | ||
| # as these older versions of jupyter will break with tornado 6 | ||
| notebook==6.0.0 ; python_version >= '3.5' | ||
| notebook==5.7.8 ; python_version < '3.0' |
There was a problem hiding this comment.
So why the two different versions now?
There was a problem hiding this comment.
According to the notebook package changelog, the 6.0.0 release fixes the issue with the 500 error on downloading a notebook in ipynb format. I can't direct link the line, but in the notes for 6.0.0 it mentions "Respect nbconvert entrypoints as sources for exporters", which was causing the 500.
Apparently nbconvert in 5.7.8 works fine for Python2 ¯_(ツ)_/¯
There was a problem hiding this comment.
Ohh, so fixing the 500 error requires 6.0.0 on python3? Interesting. Is there any reason to keep python2 on 5.7.8? If we're bumping one, it seems like we might as well bump the other
There was a problem hiding this comment.
IIRC there was an issue with python 2 and 6.0.0 but I’ll double check just to make sure
There was a problem hiding this comment.
They actually dropped support for python2 in 6.0.0
There was a problem hiding this comment.
😆 😭 Wonder when we'll be able to drop support for it... Can we add a comment explaining why 5.7.8 is needed for python2? Otherwise I think future us may keep trying to upgrade it.
| @@ -28,7 +28,7 @@ def find_and_install_requirements(requirements_path, c): | |||
|
|
|||
| def config_jupyter(c): | |||
| # Jupyter Configuration | |||
| c.NotebookApp.ip = '*' | |||
| c.NotebookApp.ip = '0.0.0.0' | |||
There was a problem hiding this comment.
What are the reasons for/consequences of this change?
There was a problem hiding this comment.
This change is necessary to fix this error when starting the notebook image: ValueError: '' does not appear to be an IPv4 or IPv6 address (this bug is referenced in the JIRA ticket)
There was a problem hiding this comment.
Right, we've run into that error before, but there was supposed to be a fix introduced in 5.7.8. Does that fix not actually work, or is it not included in 6.0.0?
There was a problem hiding this comment.
I don't think the fix completely works. On the python2 notebook, when I change the value back to *, I get a different error:
socket.gaierror: [Errno -2] Name or service not known
The change above fixes this for python2 and doesn't seem to affect the other notebooks.
There was a problem hiding this comment.
Ahh, that's too bad. 😞 Okay then.
|
@leanne73 Let me know if I answered your questions or if you need some clarification, either here or offline. Thanks! |
|
@leanne73 Does this PR look ready for release? |
This PR updates the notebook package version to 5.7.8 for Python 2 and to 6.0.0 for Python 3 (in order to fix, among other things, the 500 error when trying to download a notebook as an ipynb file)