-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moon localisation to town #247
Comments
@Gy0m Actually, there should be no difference for different locations. Probably, we should detect the hemisphere basing on the IP of the client querying wttr.in/Moon, @Gy0m Or do you mean some other localisation? |
Should be able to specify a location as well or whatever. Sent with GitHawk |
pyphoon supports hemispheres now (thanks to @martinbra), |
Thanks @chubin , I'm glad to help! |
I'm not sure there is anything to "warn" the user about. I suspect that if the user is in the southern hemisphere, then they are aware of that :P What about tropical/equatorial zones? Is this (wonderful btw) moon picture flexible enough to be rotated by an arbitrary angle? |
Unfortunately no. Ascii art is difficult to rotate. Chubin has a link to Unicode about equatorial zones (pdf warning) in the main readme.md which humorously talk about why it is a little bit of non sense to rotate the moon to the tropical viewer. Check out https://github.com/chubin/pyphoon/blob/master/src/lib/moons.py for the original moon ascii art. Actually, it comes from a 1979's pascal code by Jef Poskanzer, as stated in the pyphoon readme. @chubin , I tried, but windows was making things hard for me (V2 uses pyjq which doesn't work on windows), so I gave up trying to run the server (this and a lot different configurations for windows). I am for the warning, as some users may be unaware of the changes made. |
I believe moon rotation for tropical zones is an overkill. Of course, it is an interesting feature, but we have so many feature requests in other areas, so I think that it is better to implement them first. @martinbra I believe, the best option for running/developing linux apps on Windows, is Docker; it is quite easy to install/manage Docker on Windows now. |
@martinbra Yeah, I incidentally happen to be the author of that link addition in the readme X) Fair enough, I agree that it's much more difficult to rotate ascii art than to rotate yourself while gaping at the moon ;) Thank you for this nice addition! |
@iago-lito , oops, "blame" on me for not having blamed the readme.md. Thanks for the documentation.
@chubin Ok, I will do it. Is google translator accurate enough to fullfill every language? |
@martinbra no, of course not, but we have a lot of supporters, who will help us with the translation. We should just add the English version, and they will do the rest. Martin, a short question: do you have a twitter account? I want to publish the moon update, and wanted to mention you |
@chubin
ok, I will do it friday or saturday.
My twitter is @Martinbmeier , there is not much happening there but I
appreciate it.
Em qui., 24 de set. de 2020 às 14:02, Igor Chubin <[email protected]>
escreveu:
… @martinbra <https://github.com/martinbra> no, of course not, but we have
a lot of supporters, who will help us with the translation. We should just
add the English version, and they will do the rest. Martin, a short
question: do you have a twitter account? I want to publish the moon update,
and wanted to mention you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#247 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHEKZXMPLSNEKMEUDDMEED3SHN3SDANCNFSM4GDQK5AA>
.
|
I'm up for the French translation btw, where/when do I get started? :) |
@chubin and @iago-lito :
|
I think I'm pending to opt for the opt2, since any moon with argument n > 27 will hide the text to the right of the moon. |
and... should |
I like opt1 because it packs informations together, but I'm not sure I understand your concern about "moon with argument"? If it's about text width, would dropping the leading |
@iago-lito the thing is that pyphoon (actually the original phoon too), hides the text to the right of the moon if we show a moon with size bigger than 27. Since wttr.in/moon uses a standard size, it won't impact the users here, only those who use pyphoon from the CLI. See the example below:
That's an interesting idea. I would then change the argument -S to show the shown hemisphere, instead of just warning if it was rotated as in "North|South Hemisphere", just below the phase/time as it follows. @chubin what do you think?
|
I agree that Another question is should we show the hemisphere warning for the north hemisphere (which I expect is 98% of the queries), or just imply it. |
I've added @iago-lito veuillez vérifier ma traduction en français, car mon français laisse beaucoup à désirer :) |
Oh, I see. Yes, better to just imply it. |
Je préférerais la première (l'option 1), mais court (simplement |
Notice that the shortening introduces a slight ambiguity, since it is unsure now whether the message refers to the moon hemisphere, or the earth hemisphere from which the moon is looked at. Can we afford I would rather keep the "warning" in both hemispheres, even if 98% the queries involve north hemisphere:
BTW, not even sure why to call it a "warning", this information is perfectly expected, right? Ok for the French-checking, mais je ne suis pas certain d'avoir compris où trouver les fichiers à traduire, où sont-ils ? X) (how come you two like switching to French this way? :P) |
Open https://github.com/chubin/pyphoon/blob/master/src/lib/translations.py and check chubin's translation. Click on edit if needed (top right)... maybe you will have to fork the repository first. |
@chubin I created a PR, but didn't considered @iago-lito last considerations, since I hadn't seen them at the time. Let me know what you think and if there is any modification needed. |
This: And regarding the as seen from moon/from earth controversy, I think it is enough to add some brackets, braces or make it somehow visible, that the Oups, je suis désolé, j'ai lié le fichier à une Issue, mais pas à celle-ci. chubin/pyphoon#1 (I believe, it would be very an interesting experience to live in the world, where Github, and in general the software developers lingua-franca is French; sort of the world of Jules Verne; very very cool :) |
I like the idea of the text with both North and South warnings at the side of the moon.
I think that we could explain it in the function 'help' text and in README.md, that we are seeing the moon from the Earth northern/southern hemisphere, and keep the displayed text short. We could also explain that due to the revolution and rotation of the moon being synced, we always see the same face of the moon (with little variation), so there is no point in talking about the moon hemisphere. Qu'est-ce que vous en pensez? |
All ok for me :) This fr line looks perfect, @chubin ton français lunaire ne laisse rien à désirer :P Thank you @martinbra for your PR, I appreciate that you honour the moon, and please ping me if I've forgotten something (or whenever you need).
(I'm not sure I'm getting you on this one. Do you mean you would like it if the OSS community default language were French instead of English, because it is so romantic? Yeah, that would definitely be cool :) |
Thanks @iago-lito , would you like to write about the hemispheres warning to be included in the documentation? Look at the pyphoon README.md and see how we can benefit from a hearthwarming explanation. :) I've updated it on my branch, if you want to see the latest version. |
Looks good to me. Let's merge it, deploy it and see how it looks like live |
Thanks. I will update the PR. |
@martinbra Okay, I'm having a look at this file (although I'm too lazy to open a PR, maybe I can just post a draft here ? 0:) I see only 3 relevant lines. My intent is to flesh them so they feel both informative and crystal clear.
What do you think ? :) |
|
@iago-lito Thanks for your work! Very well explained. Do you want me to commit it? I have some considerations below:
I liked it. I would only keep
Actually it defaults to
In this case we will politely ask them to provide the relevant ASCII art in all the needed sizes 0:) |
@iago-lito , I was re-reading your sugestions, and would like to exchange some ideas. What do you think of the following?
Shouldn't it be
change to -> I think it would clarify even further. |
@martinbra Yupe, okay to all :)
Don't hesitate to commit if you like it now :) |
What is open here? Only the translations or something else? |
Oh, sorry @chubin we ended up talking about pyphoon here. You can close this issue. |
i was right |
"Is it possible to localize moon to town it appears ?"
the command : curl -4 https://fr.wttr.in/Moon show me the moon in the coutry where i live
The text was updated successfully, but these errors were encountered: