Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: support export foyer metrics via otel #3204

Merged
merged 6 commits into from
Dec 30, 2024
Merged

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Nov 27, 2024

Signed-off-by: MrCroxx [email protected]## Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Support otel metrics export

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv self-requested a review December 5, 2024 16:21
Cargo.toml Outdated
Comment on lines 29 to 32
opentelemetry = { version = "0.27.0", default-features = false, features = [
"trace",
"metrics",
] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep these to one line so sort on the deps is feasible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

BTW, I introduced a configuration file for taplo (which is used by VS code "Even Better Toml" and command line tool "taplo", the tools are mostly used to format .toml file in the Rust community).

Copy link
Contributor Author

@MrCroxx MrCroxx Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also enable the validator in CI. IMHO, using a tool for formatting and validating is always better than human reviewing.

FYI - taplo: https://taplo.tamasfe.dev/

..and add formatter configuration for taplo.

Signed-off-by: MrCroxx <[email protected]>
@MrCroxx MrCroxx marked this pull request as ready for review December 12, 2024 06:14
@rescrv rescrv merged commit f83d1c5 into chroma-core:main Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants