Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init option type setting it as optional #867

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

stockiNail
Copy link
Collaborator

Fix #866

@stockiNail stockiNail added bug types Typescript type changes labels Mar 15, 2023
@stockiNail stockiNail added this to the 2.2.1 milestone Mar 15, 2023
@stockiNail stockiNail requested a review from LeeLenaleee March 15, 2023 11:20
@stockiNail
Copy link
Collaborator Author

@kurkle @LeeLenaleee if the PR is ok for you and then you will approve it, we could release a bug fixing release. What do you think? Too early?

@stockiNail stockiNail merged commit 89e6c48 into chartjs:master Mar 15, 2023
@stockiNail stockiNail deleted the fixInitTypes branch March 15, 2023 14:02
@stockiNail
Copy link
Collaborator Author

Thank you @LeeLenaleee and apologize for the bug. I haven't recognized it due to my poor knowledge on TS :(.

@LeeLenaleee
Copy link
Collaborator

Don't you worry mistakes happens to us all, it also slipped by in the review so we are equally to blame, important thing is that it's fixed 👍

@kurkle
Copy link
Member

kurkle commented Mar 15, 2023

I would suggest releasing bug fixes asap. There are plenty of version numbers to use, so no need to collect weeks or months of work to one (and keep the bug(s) unfixed meanwhile).

@stockiNail
Copy link
Collaborator Author

I would suggest releasing bug fixes asap. There are plenty of version numbers to use, so no need to collect weeks or months of work to one (and keep the bug(s) unfixed meanwhile).

Got it !! (in fact, I had already prepared the bump PR ;)). I'll not ask anymore!

@stockiNail
Copy link
Collaborator Author

@kurkle do you want to release in the next days a version 3 with only PR #838 to fix the type=module issue?

@kurkle
Copy link
Member

kurkle commented Mar 16, 2023

I don't have any objections to that, sounds good.

@stockiNail
Copy link
Collaborator Author

Ok! Let me do some additional tests because I think that the peerDependencies of Chart.js could change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with AnnotationOptions type in 2.2.0 version
3 participants