-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix init option type setting it as optional #867
Conversation
@kurkle @LeeLenaleee if the PR is ok for you and then you will approve it, we could release a bug fixing release. What do you think? Too early? |
Thank you @LeeLenaleee and apologize for the bug. I haven't recognized it due to my poor knowledge on TS :(. |
Don't you worry mistakes happens to us all, it also slipped by in the review so we are equally to blame, important thing is that it's fixed 👍 |
I would suggest releasing bug fixes asap. There are plenty of version numbers to use, so no need to collect weeks or months of work to one (and keep the bug(s) unfixed meanwhile). |
Got it !! (in fact, I had already prepared the bump PR ;)). I'll not ask anymore! |
I don't have any objections to that, sounds good. |
Ok! Let me do some additional tests because I think that the peerDependencies of Chart.js could change. |
Fix #866