Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CUGAN input/output channels configurable for all versions #285

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Make CUGAN input/output channels configurable for all versions #285

merged 1 commit into from
Jul 11, 2024

Conversation

RunDevelopment
Copy link
Member

UpCunet4x and UpCunet2x_fast now use the in_channels and out_channels parameters.

@joeyballentine
Copy link
Member

Didnt you say this breaks the arches?

@RunDevelopment
Copy link
Member Author

No, I said that in_channels == out_channels is required by all CUGAN arches. So this change is fine as long as people specify the same in and out channels.

@joeyballentine joeyballentine merged commit ce00b4a into main Jul 11, 2024
8 checks passed
@joeyballentine joeyballentine deleted the cugan-inout-channels branch July 11, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyballentine joeyballentine joeyballentine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RunDevelopment @joeyballentine