Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lighthouse timeout on pages with video players #6704

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Fix Lighthouse timeout on pages with video players #6704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions cfgov/unprocessed/js/organisms/VideoPlayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function VideoPlayer( element ) {
return UNDEFINED;
}

// Load a default thumbnail image if we're not using a custom one.
// Load the thumbnail from YouTube if we haven't specified one in the DOM.
if ( _videoId && !_showCustomThumbnail ) {
_imageLoad( youTubeAPI.fetchImageURL( _videoId ) );
}
Expand Down Expand Up @@ -134,11 +134,23 @@ function VideoPlayer( element ) {
*/
function _imageLoad( imageURL ) {
_imageDom.addEventListener( 'load', _imageLoaded );
_imageDom.addEventListener( 'error', _imageLoadDefault );
_imageDom.addEventListener( 'error', _imageLoadFailed );

_imageDom.src = imageURL;
}

/**
* Error handler for thumbnail image loading.
* If for some reason we can't load the specified thumbnail image, we
* should try to load the default thumbnail. But don't do that if we've
* already tried and failed to do so once.
*/
function _imageLoadFailed() {
if ( _imageDom.src === _defaultThumbnailURL ) {
_imageLoadDefault();
}
}

/**
* Event handler for when image src attribute is set.
*/
Expand Down