Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm,deb: conditionally package crimson-store-nbd in ceph-test #38608

Merged
merged 2 commits into from
Dec 16, 2020
Merged

rpm,deb: conditionally package crimson-store-nbd in ceph-test #38608

merged 2 commits into from
Dec 16, 2020

Conversation

tchaikov
Copy link
Contributor

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@tchaikov
rpm: package crimson-store-nbd in ceph-test package
5af1773 
when building with seastar enabled, package crimson-store-ndb in
"ceph-test" package. "crimson-store-nbd" is a new tool for testing
seastore using nbd.

Signed-off-by: Kefu Chai <[email protected]>
@tchaikov
debian: install crimson-store-nbd with pkg.ceph.crimson profile
8e4cf7c 
Signed-off-by: Kefu Chai <[email protected]>
@tchaikov
Copy link
Contributor Author

https://shaman.ceph.com/builds/ceph/wip-crimson-build/8e4cf7cbc541feb37efdb6218eb2306ab4c7be4d/

@tchaikov tchaikov requested a review from athanatos December 16, 2020 09:30
@ideepika
Copy link
Member

@tchaikov updated fix for #31358, but seeing a failure that might be related to this PR, updating it here in case if it helps/still related to above issue, let me know, thanks.

Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/16.0.0-8356-g29a932c2/rpm/el8/BUILDROOT/ceph-16.0.0-8356.g29a932c2.el8.x86_64
error: Installed (but unpackaged) file(s) found:
   /usr/bin/crimson-store-nbd
   /usr/lib/debug/usr/bin/crimson-store-nbd-16.0.0-8356.g29a932c2.el8.x86_64.debug


RPM build errors:
    Duplicate build-ids /home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/16.0.0-8356-g29a932c2/rpm/el8/BUILDROOT/ceph-16.0.0-8356.g29a932c2.el8.x86_64/usr/bin/ceph-osd and /home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/16.0.0-8356-g29a932c2/rpm/el8/BUILDROOT/ceph-16.0.0-8356.g29a932c2.el8.x86_64/usr/bin/crimson-osd
    Duplicate build-ids /home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/16.0.0-8356-g29a932c2/rpm/el8/BUILDROOT/ceph-16.0.0-8356.g29a932c2.el8.x86_64/usr/lib/debug/usr/bin/ceph-osd-16.0.0-8356.g29a932c2.el8.x86_64.debug and /home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/16.0.0-8356-g29a932c2/rpm/el8/BUILDROOT/ceph-16.0.0-8356.g29a932c2.el8.x86_64/usr/lib/debug/usr/bin/crimson-osd-16.0.0-8356.g29a932c2.el8.x86_64.debug
    Installed (but unpackaged) file(s) found:
   /usr/bin/crimson-store-nbd
   /usr/lib/debug/usr/bin/crimson-store-nbd-16.0.0-8356.g29a932c2.el8.x86_64.debug

https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos8,DIST=centos8,MACHINE_SIZE=gigantic/49410//consoleFull

@athanatos
Copy link
Contributor

jenkins retest this please

1 similar comment
@athanatos
Copy link
Contributor

jenkins retest this please

@athanatos athanatos mentioned this pull request Dec 16, 2020
Merged
@athanatos
Copy link
Contributor

flake8 create: /home/jenkins-build/build/workspace/ceph-pull-requests/qa/.tox/flake8
flake8 installdeps: flake8
WARNING: Discarding $PYTHONPATH from environment, to override specify PYTHONPATH in 'passenv' in your configuration.
flake8 installed: DEPRECATION: --find-links option in pip freeze is deprecated. pip 21.2 will remove support for this functionality. You can find discussion regarding this at pypa/pip#9069 /home/jenkins-build/build/workspace/ceph-pull-requests/qa/wheelhouse,flake8==3.8.4,importlib-metadata==3.3.0,mccabe==0.6.1,pycodestyle==2.6.0,pyflakes==2.2.0,typing-extensions==3.7.4.3,zipp==3.4.0
flake8 run-test-pre: PYTHONHASHSEED='1670938424'
flake8 run-test: commands[0] | flake8 --select=F,E9 --exclude=venv,.tox
./tasks/cephfs/test_volume_client.py:848:9: F841 local variable 'out' is assigned to but never used
./tasks/cephfs/test_volume_client.py:910:9: F841 local variable 'out' is assigned to but never used
ERROR: InvocationError for command /home/jenkins-build/build/workspace/ceph-pull-requests/qa/.tox/flake8/bin/flake8 --select=F,E9 --exclude=venv,.tox (exited with code 1)

is the failure

@athanatos
Copy link
Contributor

I don't think this is related, @djgalloway how do I override?

@djgalloway
Copy link
Contributor

jenkins retest this please

@athanatos
Copy link
Contributor

athanatos commented Dec 16, 2020 •
edited
Loading

Failure seems to be due to aa4beb3 merged today @batrick ^ qa/tasks/test_volume_client.py from the CVE-2020-27781 merge.

@neha-ojha
Copy link
Member

jenkins retest this please

@neha-ojha
Copy link
Member

Failure seems to be due to aa4beb3 merged today @batrick ^ qa/tasks/test_volume_client.py from the CVE-2020-27781 merge.

the fix #38625 for this has merged, hopefully make check won't complain this time

@neha-ojha
Copy link
Member

@athanatos fyi, make check passed

@tchaikov tchaikov merged commit 4294fcf into ceph:master Dec 16, 2020
@tchaikov tchaikov deleted the wip-crimson-build branch December 16, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athanatos athanatos athanatos approved these changes

Assignees
No one assigned
Labels
build/ops crimson
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tchaikov @ideepika @athanatos @djgalloway @neha-ojha