Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves ceph.conf settings about running a ceph-mon #114

Closed
wants to merge 2 commits into from

Conversation

hufman
Copy link
Contributor

@hufman hufman commented Apr 7, 2014

Only ceph-mon ceph.conf files need fsid and initial nodes.
Nodes that aren't ceph-mon don't need them.
This is particularly important for nodes that aren't in the same
environment as the ceph cluster.

@hufman
Copy link
Contributor Author

hufman commented Apr 7, 2014

http://tracker.ceph.com/issues/3253 says that they are also needed for OSD volumes, to handle drive hotplugs. Tweaking now!

@hufman
Copy link
Contributor Author

hufman commented Apr 18, 2014

How does it look?

@guilhem guilhem self-assigned this Apr 18, 2014
@guilhem guilhem added this to the 1.0 milestone Apr 28, 2014
@guilhem
Copy link
Contributor

guilhem commented May 6, 2014

@hufman can you test f48fa95 ?
I may fix it while debugging aio

@hufman
Copy link
Contributor Author

hufman commented May 6, 2014

I ran test-kitchen on that commit. The .kitchen.yml file wanted to test 10.04 and 12.04, I needed to change it to test 12.04 and 14.04, because Ceph doesn't host deb packages for the 10.04 version.
The Centos-6 test failed because it wanted to fetch http://ceph.com/rpm-dumpling/el6/noarch/ceph-release-1-0.el6.noarch.rpm/repodata/repomd.xml. There is a file at .../ceph-release-1-0.el6.noarch.rpm, and there is also a file at .../repodata/repomd.xml. I suspect either the repository attribute has to be changed to just be the directory, or the yum_repository invocations have to point to the directory itself. To continue the test, I used File.dirname inside the recipes/rpm.rb file.
Centos 5.9 had to be bumped to Centos 5.10.
After those change, running "kitchen test" completed successfully. It just seemed to install the software but not actually configure or run it. Running kitchen test 'aio-ubuntu-1404' seemed to run the full installation process and it seemed to work, I'm going to let the full test suite run tonight.

@guilhem
Copy link
Contributor

guilhem commented May 7, 2014

@hufman thank you for this tests, do a PR when your work is done :)

Walter Huf added 2 commits May 28, 2014 16:47
Only ceph-mon ceph.conf files need fsid and initial nodes.
Nodes that aren't ceph-mon don't need them.
This is particularly important for nodes that aren't in the same
environment as the ceph cluster.
@hufman
Copy link
Contributor Author

hufman commented May 28, 2014

I've rebased this PR onto the new master. I see that the cookbook automatically generates an FSID if there isn't one, in the conf.rb recipe. However, I think this will be confusing for ceph clients that don't need to have the FSID set, because they will generate their own FSID independent from the rest of the cluster. This won't cause problems, it will just look confusing in the ceph.conf file.
Should a similar approach to the monsecret (#121) be used? The first mon node could generate and save an FSID, and other mon and osd nodes will automatically use it if they don't have it but need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants