-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzzy counts work for /index.php vs / are not grouped together #272
Comments
Is it safe to assume that the index is always 'index.php'? |
Note that there may be cases where a php file is used but the path appears afterwards causing it to look like it was a folder. An example of this might be the proxy pass or file used in our BBB fork. But aside from these small instances, it's unlikely that a trailing slash is not considered an index page as that is kind of a common server page setup many sites use. |
After consideration, I believe that is is simpler and safer to work with script names exclusively (for web requests). |
Add @param description Potential CI fix
[#272] Update unit tests for new logic
We should fix this at the grouping level, any urls which are the same like / and /index.php should be merged into the same group, probably without the index.php
Special case, show the / at the root level as '/' and not as an empty string
The text was updated successfully, but these errors were encountered: