Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Split client into client and iframe client #329

Merged
merged 1 commit into from
Jun 12, 2016
Merged

Split client into client and iframe client #329

merged 1 commit into from
Jun 12, 2016

Conversation

nikgraf
Copy link
Member

@nikgraf nikgraf commented Jun 12, 2016

Until now we both parts where part of the client and just determined on a condition.

The idea here is for once to have cleaner setup, but also to improve the execution time. Unfortunately this will bring just save us around 50 milliseconds per iFrame (on my machine).

Previous loading results with client & iframe client combined:
screen shot 2016-06-12 at 08 12 38

Loading results with client & iframe client being separate:
screen shot 2016-06-12 at 08 10 37

The big chunk definitely is the user-bundle with the app inside taking up around 700milliseconds to evaluate:
screen shot 2016-06-12 at 08 07 15

Even in our dev example the file-size of the user-bundle is already quite large with 9.6 MB

user-bundle

@mxstbr
Copy link
Contributor

mxstbr commented Jun 12, 2016

Holy hell what is in that user-bundle?

@nikgraf
Copy link
Member Author

nikgraf commented Jun 12, 2016

@mxstbr all the webpack, hot-reloading, all libraries, the app, inline source maps (all uncompressed)

@mxstbr
Copy link
Contributor

mxstbr commented Jun 12, 2016

all uncompressed

That sounds like something we can change?

@nikgraf
Copy link
Member Author

nikgraf commented Jun 12, 2016

@mxstbr yeah, that might help a bit on the other hand it will slow down recompiling with hot reloading afaik - will need some perf testing

@nikgraf nikgraf merged commit a01f774 into master Jun 12, 2016
@nikgraf nikgraf deleted the iframe-client branch June 12, 2016 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants