This repository has been archived by the owner on May 1, 2024. It is now read-only.
Split client into client and iframe client #329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now we both parts where part of the client and just determined on a condition.
The idea here is for once to have cleaner setup, but also to improve the execution time. Unfortunately this will bring just save us around 50 milliseconds per iFrame (on my machine).
Previous loading results with client & iframe client combined:
Loading results with client & iframe client being separate:
The big chunk definitely is the user-bundle with the app inside taking up around 700milliseconds to evaluate:
Even in our dev example the file-size of the user-bundle is already quite large with 9.6 MB