-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array forwards to the prelude #4682
Open
danakj
wants to merge
10
commits into
carbon-language:trunk
Choose a base branch
from
danakj:proposal-array-forwards-to-th
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Array forwards to the prelude #4682
danakj
wants to merge
10
commits into
carbon-language:trunk
from
danakj:proposal-array-forwards-to-th
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danakj
added
proposal
A proposal
proposal draft
Proposal in draft, not ready for review
labels
Dec 13, 2024
danakj
force-pushed
the
proposal-array-forwards-to-th
branch
from
December 13, 2024 15:02
e5ce9a2
to
1eac5a0
Compare
danakj
force-pushed
the
proposal-array-forwards-to-th
branch
4 times, most recently
from
January 8, 2025 19:35
7729072
to
41cdb12
Compare
github-actions
bot
added
proposal rfc
Proposal with request-for-comment sent out
and removed
proposal draft
Proposal in draft, not ready for review
labels
Jan 8, 2025
We propose to add `Core.Array(T, N)` as a library type in the `prelude` library of the `Core` package. Since arrays are a very frequent type, we propose to privilege use of this type by providing a builtin `Array(T, N)` type that resolves to the `Core.Array(T, N)` type. Users can model this as an implicit import of the `Core.Array(T, N)` type into the global scope, much like the implicit import of the `prelude` library of the `Core` package.
danakj
force-pushed
the
proposal-array-forwards-to-th
branch
from
January 8, 2025 19:39
41cdb12
to
fca98cc
Compare
imports are typically in the file scope, they don't become part of the package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We propose to add
Core.Array(T, N)
as a library type in theprelude
library of theCore
package. Since arrays are a very frequent type, we propose to privilege use of this type by providing a builtinArray(T, N)
type that resolves to theCore.Array(T, N)
type. Users can model this as an implicit import of theCore.Array(T, N)
type into the global scope, much like the implicit import of theprelude
library of theCore
package.