-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding The unsaturated callback to the queue #868 #869
Conversation
@@ -879,6 +882,8 @@ | |||
concurrency: concurrency, | |||
payload: payload, | |||
saturated: noop, | |||
unsaturated:noop, | |||
buffer: concurrency / 4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the point of the buffer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the difference between the saturation point and a buffer point you want in order to say the queue is unsaturated ...
Here I'm saying once the queue has been saturated i want it to be at 25% - concurrency in order to say the queue is unsaturated..
Example
concurrency = 10 //workers
saturated = 10 //items in queue
unsaturated = 7.5 //items in queue or less..
If you can rebase from master, I'll merge this. |
+1 |
ok will do |
@aearly updated the branch |
Will this be merged into master? 2016-01-19 15:14 GMT-03:00 Ernie Casilla [email protected]:
|
yes i assume it will is there another branch i should be making the PR into? |
We're currently going through a modularization phase (#996) so it would be more useful if you could merge it into that branch ( Sorry, things changed a lot since my last comment. |
This was closed without the PR? |
It was completed in another PR. |
This is already available on master or should I checkout another branch? |
It's on master. We're probably going to do a v2.0.0-rc.2 soon.
|
I needed this function to allow be to create a simple backoff notification for the producers of data on to a queue.