UX: Allows going back to dashboard when cancelling from there #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 25, 2021 12:04
# Conflicts: # pages/cancel/[uid].tsx
Also: - Linting - Type fixes
|
@zomars is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
KATT
suggested changes
Aug 26, 2021
added 12 commits
August 26, 2021 12:29
…0525 # Conflicts: # pages/bookings/index.tsx
# Conflicts: # pages/bookings/index.tsx
# Conflicts: # pages/cancel/[uid].tsx # Conflicts: # pages/cancel/[uid].tsx
Also: - Linting - Type fixes # Conflicts: # pages/cancel/success.tsx
# Conflicts: # pages/bookings/index.tsx
# Conflicts: # pages/cancel/[uid].tsx
…0525 # Conflicts: # pages/bookings/index.tsx # pages/cancel/[uid].tsx # pages/cancel/success.tsx
|
Rebased from main @KATT ready for re-review |
|
@zomars can you provide screenshots or better, a loom.com video? |
KATT
suggested changes
Sep 15, 2021
added 3 commits
September 15, 2021 08:45
# Conflicts: # pages/bookings/index.tsx # pages/cancel/[uid].tsx # pages/cancel/success.tsx
|
Since this functionality is already implemented, this PR just became minor type fixes @KATT Feel free to review, close or merge as you see fit. |
emrysal
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #525
This PR also fixes linting and typing errors of the modified pages. The class names were sorted with the recommended tailwind extension that you have on the repo.