Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use DataTable for /bookings #18589

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor: use DataTable for /bookings #18589

wants to merge 2 commits into from
+186 −144

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Jan 10, 2025 •
edited
Loading

What does this PR do?

  • Fixes CAL-4991

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

/bookings/[...] should work the same (infinite scrolling w/ loading more + filtering)

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 4:46pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 4:46pm

@linear Linear
Copy link

linear bot commented Jan 10, 2025

CAL-4991 Use DataTable in /bookings

@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 10, 2025
@eunjae-lee eunjae-lee force-pushed the eunjae/cal-4991-refactor-filters-in-bookings branch from 725e788 to 737dfe2 Compare January 10, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
consumer core area: core, team members only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunjae-lee @keithwillcode