Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create dub links if valid url #18588

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

joeauyeung
Copy link
Contributor

What does this PR do?

Only creates dub links if valid URL is passed.

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot requested a review from a team January 10, 2025 15:21
@dosubot dosubot bot added the 🐛 bug Something isn't working label Jan 10, 2025
@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 10, 2025
Copy link

graphite-app bot commented Jan 10, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/10/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/10/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 3:35pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 3:35pm

Copy link
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@keithwillcode keithwillcode self-requested a review January 10, 2025 15:55
keithwillcode

This comment was marked as outdated.

@github-actions github-actions bot marked this pull request as draft January 10, 2025 15:56
auto-merge was automatically disabled January 10, 2025 15:56

Pull request was converted to draft

@keithwillcode keithwillcode marked this pull request as ready for review January 10, 2025 15:56
@keithwillcode keithwillcode enabled auto-merge (squash) January 10, 2025 15:56
@keithwillcode keithwillcode merged commit e7df1ef into main Jan 10, 2025
39 checks passed
@keithwillcode keithwillcode deleted the shortenLinks-check-valid-url branch January 10, 2025 15:58
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants