threads: no shared function expansion #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I understand `wast`'s `Expander` correctly (which I may not!), there is no need for it to know how to create type definitions for shared functions because there is no way to write WAT that would mark a function shared in an inline way. Since the only way to create a shared function is with an explicit type ID (e.g., `(func (type $ft))`), we can set `shared = false` when a `TypeDef` must be created.
alexcrichton
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Mind opening an issue for this as a feature request on the shared-everything-threads repo? I've found it quite convenient historically to be able to write functions in the past without having to write a type ahead of time, so in the limit of time I think this'd be a neat feature to have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand
wast'sExpandercorrectly (which I may not!), there is no need for it to know how to create type definitions for shared functions because there is no way to write WAT that would mark a function shared in an inline way. Since the only way to create a shared function is with an explicit type ID (e.g.,(func (type $ft))), we can setshared = falsewhen aTypeDefmust be created.