Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix --df-swap functionality for bsf oci cmd #119

Closed
rakshitgondwal opened this issue Oct 2, 2024 · 7 comments · Fixed by #131
Closed

fix --df-swap functionality for bsf oci cmd #119

rakshitgondwal opened this issue Oct 2, 2024 · 7 comments · Fixed by #131
Labels

Comments

@rakshitgondwal
Copy link
Member

We recently got rid of the --dev flag for the bsf oci command which broke the --df-swap functionality. We need to fix this.

@Bharadwajshivam28
Copy link

Hey @rakshitgondwal I would take on this issue btw can you pls provide me some info to get started

@rakshitgondwal
Copy link
Member Author

Hey @Bharadwajshivam28!
I believe there are some blockers for this issue to be picked up yet. Will let you know once we've decided on how to tackle this.

cc @dr-housemd

@dr-housemd
Copy link
Contributor

We've decided to remove the --df-swap flag in favour of using build args in Dockerfile and recommending users to pass the image names as build args.

@rakshitgondwal rakshitgondwal added the good first issue Good for newcomers label Oct 7, 2024
@Bharadwajshivam28
Copy link

Is it ready to pick this issue? @rakshitgondwal @dr-housemd

@rakshitgondwal
Copy link
Member Author

Yes, go ahead @Bharadwajshivam28

@rakshitgondwal
Copy link
Member Author

Hey @Bharadwajshivam28, were you able to make any progress on this? Let me know if you need any help

@Bharadwajshivam28
Copy link

Hey @Bharadwajshivam28, were you able to make any progress on this? Let me know if you need any help

Hello @rakshitgondwal
I will look in this soon just quite busy will jump soon this Sunday

Horiodino added a commit that referenced this issue Nov 12, 2024
Horiodino added a commit that referenced this issue Nov 12, 2024
dr-housemd pushed a commit that referenced this issue Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants