SUP-1628: Adjustment of Organization resource Allowed API IP address state persistence #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james2791
changed the title
james2791
requested review from
jradtilbrook,
mcncl and
lizrabuya
as code owners
mcncl
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor (Organization resource): Adjustment of Organization resource Allowed API IP state
PR checklist:
docs/updated -> Internal state change alteration to fix clearing the property caseexamples/(useful to demo new field/resource)CHANGELOG.mdupdated with pending release informationBit of correction for the organinzation resource and allowed IPs - basically if you either create/update an organization and clear off the allowed IPs property in resource definition, state != plan and Terraform will complain that
nulldoesnt equal an empty string list. This addresses this edge case by setting the IP allowlist in state on creates and updates to the plan value to keep consistency