Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUP-1657: Removal of non-admin tests #457

Merged
merged 4 commits into from
Dec 20, 2023
Merged

SUP-1657: Removal of non-admin tests #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11a6469
Non admin test make target/pipeline step removed
james2791 Dec 20, 2023
3f5fc4c
Forgot the depends_on
james2791 Dec 20, 2023
1b81f6d
Changelog
james2791 Dec 20, 2023
507e3ad
Merge branch 'main' of github.com:buildkite/terraform-provider-buildk…
james2791 Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,21 +40,6 @@ steps:
files: junit-*.xml
format: junit

- label: acceptance tests - non-admin
key: testacc-nonadmin
concurrency: 1
concurrency_group: terraform-provider-acceptance-tests
command: "make testacc-nonadmin"
plugins:
- aws-assume-role-with-web-identity:
role-arn: arn:aws:iam::445615400570:role/pipeline-buildkite-terraform-provider-buildkite-main
- aws-ssm#v1.0.0:
parameters:
BUILDKITE_ORGANIZATION_SLUG: /pipelines/buildkite/terraform-provider-buildkite-main/buildkite_organization
BUILDKITE_API_TOKEN: /pipelines/buildkite/terraform-provider-buildkite-main/buildkite_api_token_nonadmin
- docker-compose#v3.9.0:
run: go

- label: build
command: "make"
plugins:
Expand All @@ -64,5 +49,4 @@ steps:
- fmt
- test
- testacc
- testacc-nonadmin
- vet
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Unreleased
- SUP-1657: Removal of non-admin tests [[PR #457](https://github.com/buildkite/terraform-provider-buildkite/pull/457)] @james2791

## [v1.2.0](https://github.com/buildkite/terraform-provider-buildkite/compare/v1.1.1...v1.2.0)

Expand Down
8 changes: 0 additions & 8 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,6 @@ test:
testacc:
TF_ACC=1 go run gotest.tools/gotestsum --format testname --junitfile "junit-${BUILDKITE_JOB_ID}.xml" ./...

# Acceptance tests, but only the ones that can pass with a non-admin API token. Non-admins can manage
# pipelines and pipeline schedules, but only if they use teams. The API token must also belong to a user
# who is a maintainer of the team.
#
# This will create, manage and delete real resources in a real Buildkite organization!
testacc-nonadmin:
TF_ACC=1 go test -v -run "TestAccPipeline(Schedule)?_.*withteams" ./...

# Generate the Buildkite GraphQL schema file
schema:
go run github.com/suessflorian/gqlfetch/gqlfetch -endpoint https://graphql.buildkite.com/v1 -header "Authorization=Bearer $${BUILDKITE_GRAPHQL_TOKEN}" > schema.graphql
Expand Down