Remove validation on provider_settings #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jradtilbrook
requested review from
mcncl,
james2791 and
lizrabuya
as code owners
mcncl
reviewed
Oct 6, 2023
mcncl
previously approved these changes
Oct 6, 2023
james2791
previously approved these changes
Oct 6, 2023
jradtilbrook
changed the title
|
Not sure if I missed that discussion, or it's been conducted internally, but why verification is removed shortly after it's been added to the provider? Just wanted to learn a little more. |
|
@scadu we discussed pros/cons internally. It's related to a few issues that were raised after the 1.0 release. Adding the validation was to try to improve the experience and reduce the occurrence of bugs, but after the issues raised and more thought/understanding, we believe the validation was more trouble than it was worth. We may come back to something in the future though, but for now it was the wrong direction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
docs/updatedexamples/(useful to demo new field/resource)CHANGELOG.mdupdated with pending release information