Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUP-1361: Add timeouts to pipeline resource api #385

Merged
merged 2 commits into from
Sep 1, 2023
Merged

SUP-1361: Add timeouts to pipeline resource api #385

merged 2 commits into from
Sep 1, 2023

Conversation

lizrabuya
Copy link
Contributor

@lizrabuya lizrabuya commented Sep 1, 2023 •
edited
Loading

PR checklist:

  • docs/ updated
  • tests added
  • an example added to examples/ (useful to demo new field/resource)
  • CHANGELOG.md updated with pending release information

@lizrabuya lizrabuya changed the title SUP 1361: Add retries to pipeline resource api SUP 1361: Add timeouts to pipeline resource api Sep 1, 2023
@lizrabuya lizrabuya changed the title SUP 1361: Add timeouts to pipeline resource api SUP-1361: Add timeouts to pipeline resource api Sep 1, 2023
@lizrabuya lizrabuya marked this pull request as ready for review September 1, 2023 03:43
jradtilbrook
jradtilbrook approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@jradtilbrook jradtilbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like how you've added that helper function for the retryable error

james2791
james2791 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@james2791 james2791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@lizrabuya lizrabuya merged commit 777660b into main Sep 1, 2023
@lizrabuya lizrabuya deleted the SUP-1361-retry-pipeline-api-request branch September 1, 2023 05:34
@james2791 james2791 mentioned this pull request Sep 6, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james2791 james2791 james2791 approved these changes

@jradtilbrook jradtilbrook jradtilbrook approved these changes

@mcncl mcncl Awaiting requested review from mcncl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizrabuya @jradtilbrook @james2791