Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUP-1402: Agent token resource retries #382

Merged
merged 6 commits into from
Aug 30, 2023
Merged

SUP-1402: Agent token resource retries #382

merged 6 commits into from
Aug 30, 2023

Conversation

james2791
Copy link
Contributor

@james2791 james2791 commented Aug 29, 2023 •
edited
Loading

feat (Timeouts/Retries): Add timeouts (provider config set) and CRUD retries to the Agent token resource.

PR checklist:

  • docs/ updated (provider docs updated previously)
  • tests added (tests migrated to t.Run())
  • an example added to examples/ (provider example updated with timeouts block)
  • CHANGELOG.md updated with pending release information

Also converted the tests with a t.Run to enable parallelism / set timeouts in test configuration (random agent token names with accTest)

@james2791 james2791 changed the title SUP-a402: Agent token resource retries SUP-1402: Agent token resource retries Aug 29, 2023
@james2791 james2791 marked this pull request as ready for review August 29, 2023 21:56
lizrabuya
lizrabuya approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@lizrabuya lizrabuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lizrabuya
lizrabuya requested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@lizrabuya lizrabuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check CRUD operations to catch errors and not proceed to update the state

@james2791 james2791 requested a review from lizrabuya August 30, 2023 03:01
@james2791 james2791 merged commit deb70c3 into main Aug 30, 2023
@james2791 james2791 deleted the SUP-1402-Agent-Token-Retries branch August 30, 2023 03:33
jradtilbrook added a commit that referenced this pull request Aug 30, 2023
@jradtilbrook
Revert "SUP-1402: Agent token resource retries (#382)"
a254414 
This reverts commit deb70c3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizrabuya lizrabuya lizrabuya approved these changes

@jradtilbrook jradtilbrook jradtilbrook approved these changes

@mcncl mcncl Awaiting requested review from mcncl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james2791 @jradtilbrook @lizrabuya