SUP-1051: Team Member resource Framework/Genqlient conversion #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y from TM GraphQL, stringvalidator add
…ite into SUP-1051-Team-Members
…ite into SUP-1051-Team-Members
james2791
requested review from
jradtilbrook,
mcncl and
lizrabuya
as code owners
mcncl
requested changes
Jul 19, 2023
jradtilbrook
suggested changes
Jul 19, 2023
mcncl
previously approved these changes
Jul 20, 2023
…ite into SUP-1051-Team-Members
jradtilbrook
approved these changes
Jul 20, 2023
|
@mcncl one more before I wrap this in 👍🙏 |
mcncl
approved these changes
Jul 20, 2023
|
🚀 |
This was referenced Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
docs/updatedexamples/(useful to demo new field/resource)CHANGELOG.mdupdated with pending release informationThis PR also introduces a
node.graphql- to its name, allows for the easy obtaining of any type from the GraphQL that implements theNodeinterface. ThegetNodequery currently has a Team Member type handling inside (with the correspondingTeamMemberValuesfragment inteam_member.graphql(note this was the approach instead of aliasing eachnodesubquery which might've re-generated the same code with different function signatures)