Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUP-1084 Add Cluster resource #301

Merged
merged 41 commits into from
Jul 5, 2023
Merged

SUP-1084 Add Cluster resource #301

merged 41 commits into from
Jul 5, 2023

Conversation

mcncl
Copy link
Contributor

@mcncl mcncl commented Jul 4, 2023 •
edited
Loading

What

  • Adds support for Cluster resource
    • All CRUD functionas + Import
    • Tested locally
  • Tests for use in CI to ensure CRUD + Import work as expected
  • Usage examples in the docs

TODO:

  • Update CHANGELOG
    • Will import latest when Queues PR merged in
  • Fix Import tests
    • Fail because resource values are null even though the resources are created fine

PR checklist:

  • docs/ updated
  • tests added
  • an example added to examples/ (useful to demo new field/resource)
  • CHANGELOG.md updated with pending release information

mcncl added 25 commits June 20, 2023 16:19
@mcncl
Initial Cluster resource work
2878e7c
@mcncl
No need for API model right now
4b24e3b
@mcncl
CRUD complete for Cluster.
7e6742f
@mcncl
Merge remote-tracking branch 'origin/main' into bm/cluster_resource
2215983
@mcncl
Saving for later development
ca27445
@mcncl
Merge in agent token changes
7120fda
@mcncl
Cluster resource complete
1115cc1
@mcncl
Improve GraphQL queries for more data.
50d26af
@mcncl
CRUD for Clusters
1cb1929
@mcncl
Cluster resource tests
19e1a57
@mcncl
Use a planmodifier to maintain state for ID and UUID
1ddf4f5
@mcncl
Bit of clean up.
1044ded
@mcncl
Merge remote-tracking branch 'origin/main' into bm/cluster_resource
a148d79
@mcncl
Fix some testing typos.
0de1392
@mcncl
Add gotest
d1257eb
@mcncl
Destroy test refactor.
fa0d167
@mcncl
GraphQL fragments.
f5e9ccd
@mcncl
Get for Cluster uses UUID
3b70603
@mcncl
State doesn't embed cluster under org
0cc2d7f
@mcncl
Destroy shuold work now
f0208aa
@mcncl
Add Import
06a7734
@mcncl
Add remote check to see if it fails
4f0546c
@mcncl
Cluster tests passing. Doesn't check remote as returns null at moment.
2f0e4a6
@mcncl
Add Cluster examples.
4cb59ed
@mcncl
The story so far.
3d16e88
@mcncl mcncl changed the title Add Cluster resource SUP-1084 Add Cluster resource Jul 4, 2023
jradtilbrook
jradtilbrook suggested changes Jul 4, 2023
View reviewed changes
buildkite/graphql/cluster.graphql Outdated Show resolved Hide resolved
buildkite/resource_cluster.go Show resolved Hide resolved
buildkite/resource_cluster.go Outdated Show resolved Hide resolved
jradtilbrook
jradtilbrook previously requested changes Jul 4, 2023
View reviewed changes
docs/resources/cluster.md Outdated Show resolved Hide resolved
docs/resources/cluster.md Outdated Show resolved Hide resolved
jradtilbrook
jradtilbrook reviewed Jul 4, 2023
View reviewed changes
go.mod Show resolved Hide resolved
@mcncl mcncl requested a review from jradtilbrook July 5, 2023 04:22
james2791
james2791 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@james2791 james2791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@mcncl mcncl dismissed jradtilbrook’s stale review July 5, 2023 04:53

Changes made.

@jradtilbrook jradtilbrook merged commit 2d2fca2 into main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james2791 james2791 james2791 approved these changes

@jradtilbrook jradtilbrook jradtilbrook approved these changes

@lizrabuya lizrabuya Awaiting requested review from lizrabuya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcncl @jradtilbrook @james2791