Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUP-863 Allow pipeline to be removed from a cluster #279

Merged
merged 9 commits into from
Jun 15, 2023
Merged

SUP-863 Allow pipeline to be removed from a cluster #279

merged 9 commits into from
Jun 15, 2023

Conversation

jradtilbrook
Copy link
Contributor

@jradtilbrook jradtilbrook commented Jun 8, 2023 •
edited
Loading

PR checklist:

  • docs/ updated
  • tests added
  • an example added to examples/ (useful to demo new field/resource)

@jradtilbrook
Copy link
Contributor Author

Closes #213

@jradtilbrook jradtilbrook marked this pull request as ready for review June 8, 2023 13:25
james2791
james2791 previously approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@james2791 james2791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ☝️

mcncl
mcncl previously approved these changes Jun 15, 2023
View reviewed changes
buildkite/resource_pipeline.go Show resolved Hide resolved
@jradtilbrook jradtilbrook dismissed stale reviews from mcncl and james2791 via 30814c1 June 15, 2023 03:09
@jradtilbrook jradtilbrook requested review from mcncl and james2791 June 15, 2023 03:10
mcncl
mcncl approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@mcncl mcncl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge

@jradtilbrook jradtilbrook merged commit 291999a into main Jun 15, 2023
@jradtilbrook jradtilbrook deleted the SUP-863 branch June 15, 2023 03:17
This was referenced Jun 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcncl mcncl mcncl approved these changes

@lizrabuya lizrabuya Awaiting requested review from lizrabuya

@james2791 james2791 Awaiting requested review from james2791

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jradtilbrook @mcncl @james2791