Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR/issue templates #272

Merged
merged 5 commits into from
May 24, 2023
Merged

Add PR/issue templates #272

merged 5 commits into from
May 24, 2023

Conversation

jradtilbrook
Copy link
Contributor

No description provided.

@jradtilbrook
Copy link
Contributor Author

Let me know if I've missed any bits we need to remember to update for PRs/releases

@jradtilbrook jradtilbrook marked this pull request as ready for review May 23, 2023 04:29
@james2791
Copy link
Contributor

james2791 commented May 23, 2023 •
edited
Loading

💪

make fmt in the new feature template?

@jradtilbrook
Copy link
Contributor Author

💪

make fmt in the new feature template?

@james2791 CI will fail anyway and won't be able to merge it and I think thats a nicer way. If all these steps could be codified into CI that would be even better!

@james2791
Copy link
Contributor

💪
make fmt in the new feature template?

@james2791 CI will fail anyway and won't be able to merge it and I think thats a nicer way. If all these steps could be codified into CI that would be even better!

Thats fair - LGTM then 👍

james2791
james2791 previously approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@james2791 james2791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lizrabuya
lizrabuya previously approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@lizrabuya lizrabuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is very helpful.

@jradtilbrook jradtilbrook dismissed stale reviews from lizrabuya and james2791 via 76bcb4a May 24, 2023 04:03
mcncl
mcncl previously approved these changes May 24, 2023
View reviewed changes
@jradtilbrook jradtilbrook requested a review from mcncl May 24, 2023 04:06
@jradtilbrook jradtilbrook merged commit b99cea8 into main May 24, 2023
@jradtilbrook jradtilbrook deleted the SUP-904 branch May 24, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcncl mcncl mcncl approved these changes

@james2791 james2791 Awaiting requested review from james2791

@lizrabuya lizrabuya Awaiting requested review from lizrabuya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jradtilbrook @james2791 @mcncl @lizrabuya