SUP-866 Add deletion protection for a pipeline #250

mcncl · 2023-04-06T00:48:19Z

This came in as a request from Slack and seems like a reasonable ask given the authority that Terraform can have over an organisation.

Add delete_protection as an option on a pipeline (defaults to false)
Add tests around the deletion_protection config
Add nice messaging for error when user tries to destroy pipeline with deletion_protection enabled

Add deletion protection for a pipeline

2bd62ad

mcncl requested a review from jradtilbrook April 6, 2023 00:48

mcncl added 8 commits April 6, 2023 11:34

Changed test names for consistency,updated config

b85d18b

Destroy errors are not supported

45caef5

Pipeline testing names inconsistent.

18c269c

Don't use foobar for everything, helpful with failures.

0ce5313

deletion_protection is only used in the context of the resource

25d75dd

Trying out some error handling

c2f60cc

Ignore deletion_protection in import pipeline as only TF relevant

da71c11

GOFMT

abb2020

jradtilbrook previously approved these changes Apr 6, 2023

View reviewed changes

Update docs for deletion_protection

dbbf097

mcncl dismissed jradtilbrook’s stale review via dbbf097 April 6, 2023 05:43

jradtilbrook approved these changes Apr 6, 2023

View reviewed changes

mcncl merged commit 958f436 into main Apr 6, 2023

mcncl deleted the support_deletion_protection branch April 6, 2023 05:50

Provide feedback