Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring API endpoints #202

Merged
merged 3 commits into from
May 26, 2022
Merged

Allow configuring API endpoints #202

merged 3 commits into from
May 26, 2022

Conversation

jradtilbrook
Copy link
Contributor

This allows users to configure the API endpoints used in the provider.

@jradtilbrook jradtilbrook requested a review from jayco May 26, 2022 06:52
Copy link

@jayco jayco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High level - LGTM - just double-checking that you have tested the changes out before merging?

@jradtilbrook
Copy link
Contributor Author

High level - LGTM - just double-checking that you have tested the changes out before merging?

Yep, the integration tests cover the happy default path and ive tested locally by specifying different URLs for the new configs 👍

@jradtilbrook jradtilbrook merged commit c4906f1 into main May 26, 2022
@jradtilbrook jradtilbrook deleted the configurable-host branch May 26, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants