SUP-1996: Fix infinite drift with Team Description (#531)

* fix: remove pointer markup for Team description so it can be computed as a String and match GraphQL response when attribute not set

* fix: change Team description data type to String, to match GraphQL responses

* fix: update functions for Team description as now a String data type

* feat/fix: set default Team Description value to an empty string, matching GraphQL response values when not configured

* fix: change Team description data type to String, to match GraphQL responses

buildkite/data_source_team.go

@@ -148,7 +148,7 @@ func updateTeamDatasourceStateFromSlug(state *teamDatasourceModel, data GetTeamF
 	state.Slug = types.StringValue(data.Team.TeamFields.Slug)
 	state.Name = types.StringValue(data.Team.TeamFields.Name)
 	state.Privacy = types.StringValue(data.Team.TeamFields.Privacy)
-	state.Description = types.StringPointerValue(data.Team.TeamFields.Description)
+	state.Description = types.StringValue(data.Team.TeamFields.Description)
 	state.IsDefaultTeam = types.BoolValue(data.Team.TeamFields.IsDefaultTeam)
 	state.DefaultMemberRole = types.StringValue(data.Team.TeamFields.DefaultMemberRole)
 	state.MembersCanCreatePipelines = types.BoolValue(data.Team.TeamFields.MembersCanCreatePipelines)
@@ -160,7 +160,7 @@ func updateTeamDatasourceState(state *teamDatasourceModel, data getNodeNodeTeam)
 	state.Slug = types.StringValue(data.Slug)
 	state.Name = types.StringValue(data.Name)
 	state.Privacy = types.StringValue(string(data.GetPrivacy()))
-	state.Description = types.StringPointerValue(data.Description)
+	state.Description = types.StringValue(data.Description)
 	state.IsDefaultTeam = types.BoolValue(data.IsDefaultTeam)
 	state.DefaultMemberRole = types.StringValue(string(data.GetDefaultMemberRole()))
 	state.MembersCanCreatePipelines = types.BoolValue(data.MembersCanCreatePipelines)

buildkite/graphql/team.graphql

@@ -2,7 +2,6 @@ fragment TeamFields on Team {
 	id
 	uuid
 	name
-	# @genqlient(pointer: true)
 	description
 	slug
 	privacy
@@ -20,7 +19,6 @@ query GetTeamFromSlug($slug: ID!){
 mutation teamCreate(
 	$organizationID: ID!
 	$name: String!
-	# @genqlient(pointer: true)
 	$description: String
 	$privacy: TeamPrivacy!
 	$isDefaultTeam: Boolean!
@@ -49,7 +47,6 @@ mutation teamCreate(
 mutation teamUpdate(
 	$id: ID!
 	$name: String!
-	# @genqlient(pointer: true)
 	$description: String
 	$privacy: TeamPrivacy!
 	$isDefaultTeam: Boolean!

buildkite/resource_team.go

@@ -11,6 +11,7 @@ import (
 	resource_schema "github.com/hashicorp/terraform-plugin-framework/resource/schema"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/booldefault"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringdefault"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/schema/validator"
 	"github.com/hashicorp/terraform-plugin-framework/types"
@@ -87,6 +88,8 @@ func (t *teamResource) Schema(ctx context.Context, req resource.SchemaRequest, r
 				Required:            true,
 			},
 			"description": resource_schema.StringAttribute{
+				Computed:            true,
+				Default:             stringdefault.StaticString(""),
 				Optional:            true,
 				MarkdownDescription: "A description for the team. This is displayed in the Buildkite UI.",
 			},
@@ -154,7 +157,7 @@ func (t *teamResource) Create(ctx context.Context, req resource.CreateRequest, r
 				t.client.genqlient,
 				*org,
 				state.Name.ValueString(),
-				state.Description.ValueStringPointer(),
+				state.Description.ValueString(),
 				state.Privacy.ValueString(),
 				state.IsDefaultTeam.ValueBool(),
 				state.DefaultMemberRole.ValueString(),
@@ -259,7 +262,7 @@ func (t *teamResource) Update(ctx context.Context, req resource.UpdateRequest, r
 			t.client.genqlient,
 			state.ID.ValueString(),
 			plan.Name.ValueString(),
-			plan.Description.ValueStringPointer(),
+			plan.Description.ValueString(),
 			plan.Privacy.ValueString(),
 			plan.IsDefaultTeam.ValueBool(),
 			plan.DefaultMemberRole.ValueString(),
@@ -322,7 +325,7 @@ func updateTeamResourceState(state *teamResourceModel, res getNodeNodeTeam) {
 	state.Slug = types.StringValue(res.Slug)
 	state.Name = types.StringValue(res.Name)
 	state.Privacy = types.StringValue(string(res.GetPrivacy()))
-	state.Description = types.StringPointerValue(res.Description)
+	state.Description = types.StringValue(res.Description)
 	state.IsDefaultTeam = types.BoolValue(res.IsDefaultTeam)
 	state.DefaultMemberRole = types.StringValue(string(res.GetDefaultMemberRole()))
 	state.MembersCanCreatePipelines = types.BoolValue(res.MembersCanCreatePipelines)