Fix single spaces in templates.

[afwn90cj93201nixr2e1re]

Fixes #1927, #1703

Proposed Changes

[codecov]

Codecov Report

Merging #1944 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1944   +/-   ##
=======================================
  Coverage   64.74%   64.74%           
=======================================
  Files          66       66           
  Lines        2377     2377           
  Branches      761      776   +15     
=======================================
  Hits         1539     1539           
  Misses        769      769           
  Partials       69       69

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7800a29...7761565. Read the comment docs.

[jtommy]

@afwn90cj93201nixr2e1re if i looked well using withespace the compiler doesn't check preserveWhitespace attrs

[jtommy]

Ok but default value is undefined, you might omit it, don't you ?

[jtommy]

I mean whitespaceOption.whitespace

[jtommy]

https://github.com/vuejs/vue/blob/3dcd85b82693765b13e866132bcaa318ef086fe5/src/compiler/parser/index.js#L99

[jtommy]

@afwn90cj93201nixr2e1re reading the TS in the future we'll able to use only 'preserve' or 'condense'

[jtommy]

I should read docs because it's an important change

[afwn90cj93201nixr2e1re]

What about this one @jtommy .

[Tofandel]

If you want to reopen this

const vuePluginConfig = {
    template: {
        isProduction: true,
        compilerOptions: {
            whitespace: 'condensed',
        }
    }
}

This is the configuration, it will not cause any issue with the build and is not a breaking change, I am using this option for all my projects as well, you may have some failing snapshots that need to be updated but that's it

Just know that if you have HTML like

<span>
  text
</span>

It will be output with the condensed option as

<span> text </span>

It is only a html compression feature and doesn't visually make any difference, only changes the output markup

So the issue will not be fixed for those cases and the eslint config should be updated to change single line components to prevent whitespaces

Those components are mostly td, i, span, strong

The doc of rollup is outdated

[afwn90cj93201nixr2e1re]

He don't wanna do it.

[afwn90cj93201nixr2e1re]

Just pls stop saying stuff like that without any deep knowledge.

Read docs about that before saying anything about 'cosmetic' changes, read ton's of issues where it was descrbied by Evan especially.
You shouldn't write code like that:

<span>
  text
</span>

It's not right, read vue docs and other stuff which related to compiler parsing, there's shouldn't be any useless spaces (also no useless LF/CRLF (new line symbols)) if they are not needed.

you know you can make pull requests to fix those issues as well

Boi, ofc i know,

and it doesn't mean there can't be a new major fixing those and new issues in a few months

Also pls stop saying that, jtommy doesnt making any breakable changes on 0.9.0+ releases coz it's gonna be brekable and that's why we wait for months/years just for getting fixes...

[jtommy]

@afwn90cj93201nixr2e1re Make a PR if you want

[Tofandel]

@afwn90cj93201nixr2e1re Wow you're so rude, you should read the doc, it's exactly what I explained

[afwn90cj93201nixr2e1re]

Bruh, i already made it.. you dont see that pr? You said that you gonna read docs, did you?

[afwn90cj93201nixr2e1re]

#1944 (comment)

[afwn90cj93201nixr2e1re]

As i said read vue develops comments before discussing things that u don't know @Tofandel.

Full vue team said that this options are useless and bo one should use them in practice.
Keep using template's, that's your choice. Im not rude, that just unpopular opinion.

[afwn90cj93201nixr2e1re]

@jtommy as i said in 0.9.0 pr we should remove extra lines, if you don't wanna add this options into compiler config (i agree with that). Just read review.