Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve QSE youtube search on upgrade #27147

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Jan 7, 2025

Resolves brave/brave-browser#42567

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Refactor changes and add comments
@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jan 7, 2025
@deeppandya deeppandya added this to the 1.75.x - Nightly milestone Jan 7, 2025
@deeppandya deeppandya requested a review from samartnik January 7, 2025 20:31
@deeppandya deeppandya self-assigned this Jan 7, 2025
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeppandya deeppandya merged commit 023b7e6 into master Jan 8, 2025
19 checks passed
@deeppandya deeppandya deleted the resolve_qse_upgrade_for_yt_search branch January 8, 2025 04:33
brave-builds added a commit that referenced this pull request Jan 8, 2025
@brave-builds
Copy link
Collaborator

Released in v1.75.154

@hffvld
Copy link
Collaborator

hffvld commented Jan 9, 2025

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 BP11.241025.006 release-keys
Brave build: 1.76.1 
Chromium: 132.0.6834.57 (Official Build) canary (64-bit) 

STEPS:

  1. Install old Brave build where the YT search thumbnail is not shown in the QSE bar, in my case Nighlty 1.75.1
  2. Launch Brave > Go through onboarding
  3. Open NTP > Tap in the URL search bar
  4. Type a query > Confirm that YT search thumbnail is not shown
  5. Tap ⚙️ icon > Confirm that YT search is not shown
  6. Upgrade Brave to Nightly 1.76.1 or higher
  7. Launch Brave > Type a query again > Verify that YT search thumbnail is shown
  8. Tap ⚙️ icon > Verify that YT is shown
  9. Close the QSE settings > Type a query again
  10. Use YT to make a search > Verify that the search results opened with https://youtube.com

ACTUAL RESULTS:

  • Verified that the YT search thumbnail is shown in the QSE bar after the Brave upgrade.
  • Verified that the YT search is shown in the QSE settings after the Brave upgrade.
  • Verified that the search results opened with https://youtube.com when using YT search on the QSE bar.

2025-01-09_10-59-39.mp4

kjozwiak pushed a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Follow up to #32843] YT search is not shown in QSE toolbar and settings screen for the upgraded profile
4 participants