Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent storage partitioning bypass with a trial when Shields active. #27042

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

goodov
Copy link
Member

@goodov goodov commented Dec 17, 2024

Prevent https://developer.chrome.com/origintrials/#/view_trial/568016503002103809 to disable storage partitioning when Brave Shields are enabled.

Resolves brave/brave-browser#42798

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov marked this pull request as ready for review December 17, 2024 14:35
@goodov goodov requested review from a team as code owners December 17, 2024 14:35
@goodov goodov requested a review from ShivanKaul December 17, 2024 14:47
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src, patches LGTM

@goodov goodov merged commit 16a3bf1 into master Jan 10, 2025
20 checks passed
@goodov goodov deleted the issues/42798 branch January 10, 2025 09:08
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 10, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google cookie persisting despite "Forget Me When I Close This Site" being enabled by default
4 participants