Added --force-next-version command line param. #1019
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gihub has suggested you as a reviewer. I've updated the issue. |
antonok-edm
reviewed
Jan 7, 2025
There was a problem hiding this comment.
IMO passing another argument around like this seems like a bit too much extra complexity for something that we'd do very rarely?
My proposal is, given that right now, the hash is generated using util.generateSHA256HashOfFile...
...let's just make a wrapper around generateSHA256HashOfFile, something like generateVersionedHashOfFile, which can prepend a number to the hashed file, and if we ever need to force an update we can bump the number.
We currently only even calculate contentHash for the adblock packages so this shouldn't require changing much.
boocmp
force-pushed
the
version_bumper
branch
2 times, most recently
from
009cc31 to
83ca30c
Compare
|
Yes, you're right, this may be the first and last time we need it. |
antonok-edm
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1018