-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Android test enviorment can run browser tests with mojom bound to frames. #27837
Comments
These tests regressed in cr110. A follow up issue is created to fix them brave/brave-browser#27837
Will re-enable when brave/brave-browser#27837 is fixed
Here's an approach I took to fix this problem for one test: brave/brave-core@67293eb. The key was to use |
Hum, I thought It hadn't worked at the time. Let me check out again. |
@arthuredelstein @sangwoo108 yes, the problem is that cosmetic filters applies to every frame so no matter what you navigate to, it will try to register the browser interface and fail. Setting the test content browser client to |
looks like there are some other issues here as well which I'm investigating |
just looking at some of the upstream browser tests that are now failing to make sure they all should be failing or move them to a follow-up |
content::SetBrowserClientForTesting() didn't work for Android. We might have to override TestContentBrowserClient.
The text was updated successfully, but these errors were encountered: