move to peer dependencies and fix test #5
+303
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
I noticed this project had pinned CDK dependencies to 1.120.0. When those are listed as direct dependencies, all consumers of the lib need to use that exact version. It's a bummer for CDK which will be fixed with the 2.0 version. For now, it's a better practice to list those dependencies as peerDependencies which lets the consumer install their own versions and warns them if they don't (npm 7 does this instead).
Also looks like some churn in the test snapshots. You might get more stability using the NodejsFunction construct.