Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peerDependencies #4

Open
elthrasher opened this issue Sep 11, 2021 · 0 comments · May be fixed by #5
Open

peerDependencies #4

elthrasher opened this issue Sep 11, 2021 · 0 comments · May be fixed by #5

Comments

@elthrasher
Copy link
Contributor

This is slightly related to #3 and you may want jsii anyway, but there's a more central issue of transitory dependencies as outlined https://dev.to/aws-builders/correctly-defining-dependencies-in-l3-cdk-constructs-45p. Switching to dev & peer dependencies is a good first step to allowing this construct to be more compatible with newer CDK releases.
@elthrasher elthrasher linked a pull request Sep 11, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move to peer dependencies and fix test elthrasher/cdk-eventbridge-socket
1 participant
@elthrasher