Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when the dialog contains a link #21

Closed
FGRibreau opened this issue Feb 27, 2012 · 2 comments
Closed

Bug when the dialog contains a link #21

FGRibreau opened this issue Feb 27, 2012 · 2 comments

Comments

@FGRibreau
Copy link

If the dialog contains a link <a> inside its body, if the user clicks on it the dialog will disappear.

This issue came from L.363

$("a", div).click(function(e) {
            e.preventDefault();
            hideSource = 'button';
            div.modal("hide");
            var handler = $(this).data("handler");
            var cb = callbacks[handler];
            if (typeof cb == 'function') {
                cb();
            }
        });

$("a", div) should be $(".modal-footer a", div)

@makeusabrew
Copy link
Collaborator

Thanks for this - you're quite right. I'll get it sorted this morning.

@makeusabrew
Copy link
Collaborator

Sorted in v2.1.1 - thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants