Prefix id params with the resource name (luckyframework#659)

CHANGELOG.md

@@ -1,5 +1,7 @@
 ### In master but no released (since v0.12)
 
+- Prefix id params with the resource name [#659](https://github.com/luckyframework/lucky/issues/659)
+
 - Added Action#url_without_query_params [#662](https://github.com/luckyframework/lucky/pull/662)
 
 - Added `Lucky::AssetHelpers.load_manifest` so that API apps don't need a blank manifest to compile.

spec/lucky/action_spec.cr

@@ -190,10 +190,10 @@ describe Lucky::Action do
     it "adds routes to the router" do
       assert_route_added? Lucky::Route.new :get, "/tests", Tests::Index
       assert_route_added? Lucky::Route.new :get, "/tests/new", Tests::New
-      assert_route_added? Lucky::Route.new :get, "/tests/:id/edit", Tests::Edit
-      assert_route_added? Lucky::Route.new :get, "/tests/:id", Tests::Show
-      assert_route_added? Lucky::Route.new :delete, "/tests/:id", Tests::Delete
-      assert_route_added? Lucky::Route.new :put, "/tests/:id", Tests::Update
+      assert_route_added? Lucky::Route.new :get, "/tests/:test_id/edit", Tests::Edit
+      assert_route_added? Lucky::Route.new :get, "/tests/:test_id", Tests::Show
+      assert_route_added? Lucky::Route.new :delete, "/tests/:test_id", Tests::Delete
+      assert_route_added? Lucky::Route.new :put, "/tests/:test_id", Tests::Update
       assert_route_added? Lucky::Route.new :post, "/tests", Tests::Create
     end
 

spec/lucky/namespaced_action_spec.cr

@@ -18,7 +18,7 @@ describe Lucky::Action do
     end
 
     it "adds routes to the router" do
-      assert_route_added? Lucky::Route.new :get, "/admin/multi_word/users/:id", Admin::MultiWord::Users::Show
+      assert_route_added? Lucky::Route.new :get, "/admin/multi_word/users/:user_id", Admin::MultiWord::Users::Show
     end
   end
 end

spec/lucky/nested_resource_action_spec.cr

@@ -30,8 +30,8 @@ describe Lucky::Action do
     end
 
     it "adds routes to the router" do
-      assert_route_added? Lucky::Route.new :get, "/projects/:project_id/tasks/:id", Projects::Tasks::Show
-      assert_route_added? Lucky::Route.new :get, "/admin/projects/:project_id/tasks/:id", Admin::Projects::Tasks::Show
+      assert_route_added? Lucky::Route.new :get, "/projects/:project_id/tasks/:task_id", Projects::Tasks::Show
+      assert_route_added? Lucky::Route.new :get, "/admin/projects/:project_id/tasks/:task_id", Admin::Projects::Tasks::Show
     end
   end
 end

src/run_macros/infer_route.cr

@@ -60,14 +60,18 @@ class InferRoute
     when "new"
       [resource, "new"]
     when "edit"
-      [resource, ":id", "edit"]
+      [resource, resource_id_param_name, "edit"]
     when "show", "update", "delete"
-      [resource, ":id"]
+      [resource, resource_id_param_name]
     else
       resource_error
     end
   end
 
+  private def resource_id_param_name
+    ":#{Wordsmith::Inflector.singularize(resource)}_id"
+  end
+
   private def resource_error
     examples = "Users::Index # Index, Show, New, Create, Edit, Update, or Delete"