[R4R] Add delist feature #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
requested review from
ackratos,
darren-liu,
HaoyangLiu,
unclezoro and
rickyyangz
yutianwu
force-pushed
the
feature/add_delist
branch
from
3860711 to
d6d29a8
Compare
ackratos
requested changes
May 6, 2019
|
|
||
| am.SetAccount(ctx, acc) | ||
|
|
||
| msg := NewNewOrderMsg(addr, "123456", Side.BUY, "XYZ-000_BNB", 1e6, 1e6) |
There was a problem hiding this comment.
the test cases here insert to different price level, try put multiple orders into same price level I guess there would be problem when you delete...
plugins/dex/plugin.go
Outdated
| // deposit period: 1 day | ||
| // voting period: 14 day | ||
| // delayed days: 3 day | ||
| const DaysToSearchForDelist = 20 |
There was a problem hiding this comment.
can we put a constrain/check on delist proposal that voting period should not exceed 14 days in case we miss search delist proposal?
There was a problem hiding this comment.
voting period should less than 14days, that's a constraint when creating a proposal
ackratos
reviewed
May 6, 2019
rickyyangz
reviewed
May 6, 2019
rickyyangz
reviewed
May 7, 2019
rickyyangz
requested changes
May 7, 2019
HaoyangLiu
reviewed
May 9, 2019
HaoyangLiu
approved these changes
May 16, 2019
yutianwu
force-pushed
the
feature/add_delist
branch
3 times, most recently
from
10a673f to
74aae58
Compare
yutianwu
force-pushed
the
feature/add_delist
branch
from
74aae58 to
d92a698
Compare
ackratos
reviewed
May 27, 2019
|
|
||
| passedTime := proposal.GetVotingStartTime().Add(proposal.GetVotingPeriod()) | ||
| timeToDelist := passedTime.Add(DelayedDaysForDelist * 24 * time.Hour) | ||
| if timeToDelist.Before(blockTime) { |
There was a problem hiding this comment.
create an else branch and log an error...
it seems an error case that IsExecuted is false but timeToDelist is after blocktime
ackratos
approved these changes
May 27, 2019
HaoyangLiu
approved these changes
May 27, 2019
rickyyangz
reviewed
May 27, 2019
plugins/dex/store/mapper.go
Outdated
| @@ -114,6 +132,65 @@ func (m mapper) UpdateTickSizeAndLotSize(ctx sdk.Context, pair types.TradingPair | |||
| return tickSize, lotSize | |||
| } | |||
|
|
|||
| func (m mapper) CanListTradingPair(ctx sdk.Context, baseAsset, quoteAsset string) error { | |||
There was a problem hiding this comment.
since we have both mapper and keeper, and for now the mapper only contains the low-level db operation. so can we put CanDelistTradingPair and CanDelistTradingPair in the keeper?
rickyyangz
reviewed
May 27, 2019
rickyyangz
approved these changes
May 27, 2019
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add delist feature * implement delist function * update * add unit test for list hooks * add delist unit test * add pair mapper unit tests * update * update test * remove delayed days * fix small issues * refactor * refactor * check delist constraints before doing it * remove panic * change days back * expand proposal search time range * add pub test * add is delisted param * get max deposit period from store * add upgrade config * update dependency * move methods in mapper to keeper * fix imports
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add delist feature * implement delist function * update * add unit test for list hooks * add delist unit test * add pair mapper unit tests * update * update test * remove delayed days * fix small issues * refactor * refactor * check delist constraints before doing it * remove panic * change days back * expand proposal search time range * add pub test * add is delisted param * get max deposit period from store * add upgrade config * update dependency * move methods in mapper to keeper * fix imports
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add delist feature * implement delist function * update * add unit test for list hooks * add delist unit test * add pair mapper unit tests * update * update test * remove delayed days * fix small issues * refactor * refactor * check delist constraints before doing it * remove panic * change days back * expand proposal search time range * add pub test * add is delisted param * get max deposit period from store * add upgrade config * update dependency * move methods in mapper to keeper * fix imports
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add delist feature * implement delist function * update * add unit test for list hooks * add delist unit test * add pair mapper unit tests * update * update test * remove delayed days * fix small issues * refactor * refactor * check delist constraints before doing it * remove panic * change days back * expand proposal search time range * add pub test * add is delisted param * get max deposit period from store * add upgrade config * update dependency * move methods in mapper to keeper * fix imports
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add delist feature * implement delist function * update * add unit test for list hooks * add delist unit test * add pair mapper unit tests * update * update test * remove delayed days * fix small issues * refactor * refactor * check delist constraints before doing it * remove panic * change days back * expand proposal search time range * add pub test * add is delisted param * get max deposit period from store * add upgrade config * update dependency * move methods in mapper to keeper * fix imports
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add delist feature * implement delist function * update * add unit test for list hooks * add delist unit test * add pair mapper unit tests * update * update test * remove delayed days * fix small issues * refactor * refactor * check delist constraints before doing it * remove panic * change days back * expand proposal search time range * add pub test * add is delisted param * get max deposit period from store * add upgrade config * update dependency * move methods in mapper to keeper * fix imports
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add delist feature * implement delist function * update * add unit test for list hooks * add delist unit test * add pair mapper unit tests * update * update test * remove delayed days * fix small issues * refactor * refactor * check delist constraints before doing it * remove panic * change days back * expand proposal search time range * add pub test * add is delisted param * get max deposit period from store * add upgrade config * update dependency * move methods in mapper to keeper * fix imports
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add delist feature * implement delist function * update * add unit test for list hooks * add delist unit test * add pair mapper unit tests * update * update test * remove delayed days * fix small issues * refactor * refactor * check delist constraints before doing it * remove panic * change days back * expand proposal search time range * add pub test * add is delisted param * get max deposit period from store * add upgrade config * update dependency * move methods in mapper to keeper * fix imports
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add delist feature * implement delist function * update * add unit test for list hooks * add delist unit test * add pair mapper unit tests * update * update test * remove delayed days * fix small issues * refactor * refactor * check delist constraints before doing it * remove panic * change days back * expand proposal search time range * add pub test * add is delisted param * get max deposit period from store * add upgrade config * update dependency * move methods in mapper to keeper * fix imports
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add delist feature * implement delist function * update * add unit test for list hooks * add delist unit test * add pair mapper unit tests * update * update test * remove delayed days * fix small issues * refactor * refactor * check delist constraints before doing it * remove panic * change days back * expand proposal search time range * add pub test * add is delisted param * get max deposit period from store * add upgrade config * update dependency * move methods in mapper to keeper * fix imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: https://github.com/binance-chain/docs-internal/wiki/Delisting
cosmos change: bnb-chain/bnc-cosmos-sdk#129
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
... reference related issue #'s here ...