"commitsSince" not recognized

[MGatner]

When I drop in the example config (modified or verbatim) I get the following warning on launch:

Unrecognized configuration keys: commitsSince

Fresh install of church as composer require --dev, both pulled version 1.7.0. I don't see any other reports of this so far; I will dig through the config code and bit and see if anything is apparent.

[MGatner]

It is because the configuration string is actual the singular commitSince:

churn-php/src/Configuration/Validator/CommitsSince.php

Line 20 in fca4871

parent::__construct('commitSince');

The Validator is actually the plural though as well. Need a maintainer to advise, then I can send a PR one way or another.

[villfa]

Thank you for the report!

The right key is commitsSince.
This regression exists since 1.6.0 and has been introduced by 1b59a42.

In my opinion we should support the 2 spellings just in case some users already use the singular form.
However the usage of commitSince must trigger a deprecation message indicating it won't be supported in the next major version.

[villfa]

FYI the fix has been released with Churn 1.7.1 :)

[MGatner]

🥳🎉🎊